Make mysql an optional dependency #212
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable
patternto be installed on a diverse range of computer systems where optional dependencies' dependencies likemysql_configaren't present we should make those dependencies optional, e.g.mysqlclient.People can then install the full set of dependencies by
pip install pattern3[mysql].Let me know if other dependencies are optional and I can add them to the
setup.pyscript