Treat closing dialog (e.g. by pressing ESC) as cancel. #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that in my project that makes heavy use of seesaw, when people hit the ESC key thinking that they will cancel the dangerous operation they changed their mind about, instead the operation is completed. This change should fix the problem within seesaw, treating the ESC key the same as pressing the Cancel button in a
seesaw/confirmdialog, rather than (as it does today) pressing the OK button. (See https://docs.oracle.com/javase/7/docs/api/javax/swing/JOptionPane.html for details.)In the mean time, I’m going to have to replace all my uses of
seesaw/confirmwith something safer.