Skip to content

spacetime-install.ps1 installs Visual C++ Redistributable if needed #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iso8859
Copy link

@iso8859 iso8859 commented Mar 6, 2025

Add VCRuntime detection and installation. This runtime is mandatory.

Description of Changes

Update the Windows powershell script to install VCRuntime.

Expected complexity level and risk

Not complex.
Download directly from Microsoft.

Testing

Tested on a clean Windows 10 machine.

Add VCRuntime detection and installation. This runtime is mandatory.
@mamcx mamcx added the community Used to mark PRs that were authored by the community (people outside of Clockwork Labs) label Mar 6, 2025
@bfops
Copy link
Collaborator

bfops commented Apr 3, 2025

Thank you for creating this! We'll try to get it reviewed!

@bfops
Copy link
Collaborator

bfops commented Apr 4, 2025

@iso8859 Can you describe what wasn't working for you originally? What actually requires this runtime? (e.g. does the installation itself fail, does it fail to build a project?)

I ask because we tested on a fresh Windows 10 + Windows 11 with all updates installed, and didn't see any issues.

@iso8859
Copy link
Author

iso8859 commented Apr 5, 2025

Hi,

This is what you get when you download the installer and run it manually on a fresh Windows 10 machine.

There is no message indicating that the installation has failed when using the powershell script.

In fact, I'm wondering whether it wouldn't be interesting to add an installation success test to the script.

image

@bfops
Copy link
Collaborator

bfops commented Apr 11, 2025

Thank you! We reproduced the issue over here.

Since this is part of the main SpacetimeDB repo, we ask contributors to sign our Contributor License Agreement (CLA) before we merge their changes.

If you're willing to sign our CLA, could you send an email to [email protected] to get the process started?

@bfops bfops changed the title Update spacetime-install.ps1 Update spacetime-install.ps1 Apr 11, 2025
@bfops bfops self-requested a review April 11, 2025 18:25
@bfops bfops changed the title Update spacetime-install.ps1 spacetime-install.ps1 installs Visual C++ Redistributable if needed Apr 11, 2025
@CLAassistant
Copy link

CLAassistant commented May 3, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Used to mark PRs that were authored by the community (people outside of Clockwork Labs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants