Disable reducer arg broadcast #2694
Open
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suirad
force-pushed
the
censor-reducer-args
branch
from
83ef792 to
2cc6e17
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
By default, reducer callbacks are broadcasted to all clients of the module. This PR adds a command line flag to
spacetime startthat when given, disables reducer arguments from being sent along with the reducer callback. It does so by swapping out the Args struct to the null version of it.Potentially solves #1837 or at least it could temporarily.
API and ABI breaking changes
None; adds an optional command line flag to
spacetime startto enable new behavior.--no-reducer-argsExpected complexity level and risk
Level is about 2. The change is pretty trivial, however the depth of that change to make it command line configurable adds a bit of complexity. There may be some unknowns that I am not aware of by not broadcasting the full args of reducers to other clients. This is mostly why I didn't make a more substantive change.
Testing
Successfully ran the repo test suite.
Additional tests against existing projects and a project to specifically to demonstrate the corrected behavior via extracting passwords from third party reducer args was done by @Lethalchip. See below images:
Setup
Use Case
Results