Added Unit Test that checks the BTreeIndexBase Column implements IComparable #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
approved these changes
Mar 24, 2025
Comment on lines
+88
to
+105
| public sealed class UserHandle : RemoteTableHandle<EventContext, User> | ||
| { | ||
| protected override string RemoteTableName => "user"; | ||
|
|
||
| public sealed class IdentityIndex : BTreeIndexBase<SpacetimeDB.Identity> | ||
| { | ||
| protected override SpacetimeDB.Identity GetKey(User row) => row.Identity; | ||
|
|
||
| public IdentityIndex(UserHandle table) : base(table) { } | ||
| } | ||
|
|
||
| public readonly IdentityIndex Identity; | ||
|
|
||
| internal UserHandle(DbConnection conn) : base(conn) | ||
| { | ||
| Identity = new(this); | ||
| } | ||
| } |
There was a problem hiding this comment.
This code won't catch problems that occur if the code generation changes in the future. To catch such problems, we'd need to write the same test against generated code. For example, we could add an index to the Message.Sender field in quickstart-chat -- these tests have access to the quickstart-chat generated code.
If you want to do that, it would be great; if not, I'm willing to merge this, but would appreciate a comment saying why this class is here. // Copy of generated code for a BTreeIndex; TODO: update if that code changes is messy but at least documents what is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to com.clockworklabs.spacetimedbsdk that checks if the BTreeIndexBase class Column implements the IComparable interface. This is the implementation side of issue clockworklabs/SpacetimeDB#2362.
API
Requires SpacetimeDB PRs
No specific PR are required for this change.
Testsuite
SpacetimeDB branch name: master
Testing
dotnet test, all checks pass.