-
Notifications
You must be signed in to change notification settings - Fork 10
TypeScript SDK: Rename address to connection ID #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me.
…-to-connection-id
While merging master into this PR, detected a bug in the Timestamp #114 impl: somehow that PR merged with the wrong field name in |
I am force overriding the tests. I was in a meeting with Phoebe and this is because of a weird code gen merging order in SpacetimeDB. It is a known issue. |
Description of Changes
Typescript SDK companion to Rename Address to ConnectionId.
Re-generate the WS API schema bindings, rename
address.ts
, replace all instances of the word "address." All mechanical. Diff is artificially large because this PR is also the first time we've re-runspacetime generate
since the new subscription API landed in public, which means there's a bunch of new WS messages in the client API folder. We don't use them, pending @cloutiertyler 's PR.Note that this PR does not change the behavior where the SDK generates its connection ID locally, and passes it to the
/database/subscribe
endpoint. This can be changed in a follow-up.API
Address
is now calledConnectionId
.Requires SpacetimeDB PRs
clockworklabs/SpacetimeDB#2220