style: fix deprecations and lints #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trait objects without the `dyn` keyword are deprecated in Rust 2018+. This was changed automatically using `cargo fix`.
Signed-off-by: Eliza Weisman <[email protected]>
Clippy warns about this. Signed-off-by: Eliza Weisman <[email protected]>
This looks nicer and fixes a clippy warning. Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
This replaces use of `iter().filter(...).next(...)` with `iter().find(...)`. Signed-off-by: Eliza Weisman <[email protected]>
`Option::unwrap_or` eagerly evaluates the argument, but `unwrap_or_else` only evaluates the arguments if the first `Option` is `None`. Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
The doc comment must be *inside* the macro invocation to be present on the macro-generated code. Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
|
Hey @hawkw thanks for your contributions. The project hasn't been quite active for a while but I appreciate the effort you put into it. It seems that CI doesn't run for some reason. Maybe it's time to migrate from Travis to Circle CI? In any case we will need to get tests to run for the PR before we can merge it. Would you be willing to look into that, too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a large number of deprecations and other lints that are
generated on newer Rust versions.