Skip to content

Add argument flags to the namespace and macroexpand transient menus#4062

Merged
bbatsov merged 3 commits into
masterfrom
feature-more-menu-flags
Jul 1, 2026
Merged

Add argument flags to the namespace and macroexpand transient menus#4062
bbatsov merged 3 commits into
masterfrom
feature-more-menu-flags

Conversation

@bbatsov

@bbatsov bbatsov commented Jul 1, 2026

Copy link
Copy Markdown
Member

Follows up the jack-in transient flags (#4061) by giving two more menus the same treatment - surfacing settings that vary per-invocation as visible infix arguments, from the survey of infix opportunities.

cider-ns-menu - refresh modes (--all, --clear, --inhibit-fns). These map to cider-ns-refresh's modes, which today are only reachable via the undiscoverable single/double/negative prefix arguments. cider-ns-refresh now also accepts a list of mode symbols (backward compatible with the scalar symbol/prefix forms), so the orthogonal inhibit-fns can combine with reload-all or clear - something the single-mode prefix couldn't express.

cider-macroexpand-menu - display (--ns=tidy|qualified|none, --meta). These map to cider-macroexpansion-display-namespaces / -print-metadata, so you pick the popup expansion's rendering up front instead of expanding and then cycling with the in-buffer togglers.

Same wrapper pattern as before: thin transient-define-suffixes read transient-args and let-bind the options, so the underlying commands stay usable outside the transients. Two commits, one per menu. Tested the arg translation for both; the menus themselves are worth an eyeball.

bbatsov added 3 commits July 1, 2026 14:43
Surface the popup macroexpansion's display knobs as transient infixes on
cider-macroexpand-menu: namespace rendering (--ns=tidy/qualified/none) and
metadata (--meta). The popup expand suffixes read those args and let-bind
the matching options, so you pick the display style up front instead of
expanding and then cycling with the in-buffer togglers.
Expose cider-ns-refresh's modes as explicit toggles on cider-ns-menu
(--all, --clear, --inhibit-fns), instead of the undiscoverable single/
double/negative prefix arguments. cider-ns-refresh now also accepts a list
of mode symbols (backward compatible with the scalar symbol/prefix forms),
so the orthogonal inhibit-fns can combine with reload-all or clear.
@bbatsov bbatsov merged commit 61adc98 into master Jul 1, 2026
13 checks passed
@bbatsov bbatsov deleted the feature-more-menu-flags branch July 1, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant