Implement clojure-ts-align
#83
Merged
+394
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrudakov
force-pushed
the
feature/16-align-forms
branch
from
69f9fa9 to
b9d8ae1
Compare
rrudakov
force-pushed
the
feature/16-align-forms
branch
from
b9d8ae1 to
15434f0
Compare
|
The initial version was very slow, so I had to do some optimizations. Now it's pretty fast even in large buffers. |
rrudakov
force-pushed
the
feature/16-align-forms
branch
from
15434f0 to
2ad63f5
Compare
rrudakov
force-pushed
the
feature/16-align-forms
branch
from
2ad63f5 to
862d391
Compare
|
Anybody? @bbatsov? |
|
I'm always around. ;-) |
Sorry for pinging you :) Could you please review this when you have a chance? I'd like to contribute more, but I don't want to keep many conflicting branches in my fork. |
|
The changes look great! Impressive work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part for #16
The code is adapted from
clojure-mode, but I usedtreesit-*API wherever it was appropriate and possible. The most difficult part is dealing with metadata, I left comments describing how it works.The function is bound to
C-c SPCinclojure-ts-mode-map, similar toclojure-mode.I also disabled
tab-indent-modeby default forclojure-ts-mode, similar toclojure-mode, otherwise it tries to use tabs for alignment and sometimes it looks ugly.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!