Open
Conversation
Foundation for the tools.deps migration: - deps.edn with aliases for Clojure version testing, test runner, ClojureScript, linters, and tools.build - build.clj with Java compilation, JAR building, install, and deploy - .cljfmt.edn extracted from project.clj cljfmt config
All targets now use clojure/clj instead of lein. The Clojure sources JAR (needed for tests) is downloaded via curl since tools.deps doesn't support Maven classifiers.
- Use clojure:temurin-*-tools-deps-noble images - Remove apt-get install (no longer needed) - Cache .gitlibs for git deps - Install Clojure CLI on Windows instead of lein - Deploy from JDK 11 (tools.build requires 11+) - Add test-inbetween-jdks to deploy requirements
- Skip lein-specific source download test when lein is not available - Add deps.edn coordinate format to README usage section
The JDK source download script needs wget, unzip, and zip which aren't in the tools-deps Docker images.
Eastwood analyzes test namespaces that import test-only Java classes (e.g. PrivateFieldClass), so compile-test-java must run first.
The test-download-sources-jar-using-lein test can never run now that project.clj is gone. The tools.deps download paths are already covered by test-download-sources-jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Leiningen with tools.deps (Clojure CLI) for building, testing, and deploying orchard. Closes #262.
The project now uses deps.edn for dependency management, tools.build for Java compilation/JAR building/deployment, and the Clojure CLI for running tests and linters. The Clojure sources JAR (needed for tests, previously handled by lein's classifier support) is downloaded via curl since tools.deps doesn't support Maven classifiers natively.
Other changes:
That's a potential first step towards switching the other projects we maintain to tools.deps as well.