Catch parsing markdown error #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawranliou
changed the title
Rename `clojurians-log.message-parser/parse2` to `parse2-inner`. Add a `parse2` function that wraps `parse2-inner` with try/catch. When error is caught, log the error and return the unparsed message.
|
Here's a snapshot if I catch any exception at the level of
|
|
Yep, this is fine. We'll get to fixing the parser next, so this is just an extra resilience layer, better show the raw message then fail on the whole page. |
dawranliou
changed the title
|
Great! Thanks for merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: issue #48
Solution:
clojurians-log.message-parser/parse2toparse2-inner.parse2function that wrapsparse2-innerwith try/catch. Whenerror is caught, log the error and return the unparsed message.