Skip to content
This repository was archived by the owner on May 19, 2020. It is now read-only.

mail: allow sending a text version of mail#1281

Open
jonathaningram wants to merge 1 commit into
cloud-gov:masterfrom
govau:ji-mail-text-version
Open

mail: allow sending a text version of mail#1281
jonathaningram wants to merge 1 commit into
cloud-gov:masterfrom
govau:ji-mail-text-version

Conversation

@jonathaningram

Copy link
Copy Markdown
Contributor

Extracted from #1280

Cleaned up the mailer tests.

@jcscottiii

jcscottiii commented Nov 13, 2017

Copy link
Copy Markdown
Contributor

@jonathaningram this looks good!
i have a question: we are thinking about moving completely to text only e-mails (thanks for this PR for moving it to send text e-mails!) and ripping out the HTML template. now if you still want the html template, we can keep it. Just want to plan accordingly.

@mogul

mogul commented Nov 13, 2017

Copy link
Copy Markdown
Contributor

I think we want to keep HTML mails, just make the default no frills!

@jonathaningram

Copy link
Copy Markdown
Contributor Author

@jcscottiii yep I think we should keep the ability to send HTML emails too.

On a semi-related note (because you mentioned that you might be making a change to sending text-only emails), you might like to take a look at these links for a PR that I have yet to make, but probably will at some stage:

The first link shows how I've incorporated a new emailtemplate package into the dashboard so that skins can provide the HTML, text and subject as separate files (basically, how to get the hard-coded "cloud.gov" subject out of Go code).

The second link shows how we are actually building our HTML email templates - in short, we use React to write out a HTML file, and the node stack also writes out the subject and text files.

The third link shows the actual Go package. It has documentation/examples so hopefully it's clear once you click through.

Let me know what you think!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants