Fix coreboot CI tests #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akira Moroo <[email protected]>
Signed-off-by: Akira Moroo <[email protected]>
|
We don't need this PR because the tests passed. I was confused. |
|
@retrage Can you reopen this with just the Jenkinsfile change? I fixed it in a less efficient place (in the Jenkins cloud setup image) and your solution is better. |
|
@rbradford I reopened as PR #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw my previous PR #74 passed all CI tests, but changes to Jenkinsfile (476060c) did not have effects. Some of the missing coreboot build dependencies make CI fail from merged PR #74.
This PR fixes this CI fail and enables an integration test with QEMU Ubuntu Focal for coreboot.