Send client heartbeast on a write timer - #254
Draft
spuun wants to merge 2 commits into
Draft
Conversation
The read timeout doubled as the heartbeat timer, so any frame from the client reset it and a client that kept sending frames itself never got one back. Also wait the full two intervals before closing a connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253
Client#read_loopsetread_timeouttoheartbeat/2and sent a heartbeat whenever that read timed out, so the proxy only spoke to a client after a period of complete inbound silence. AMQP wants the opposite: a heartbeat when nothing has been written forheartbeat/2. Any frame from the client reset the timer, so a busy client with nothing to deliver got none at all and hit itsMissedHeartbeatExceptiongrace.