Added the _check_role method to the Brain, making role matching explicit. is_admin causes user to have all roles. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I67cf63e52870d36c29e3787fb06fb7abeb74fd3a
Change-Id: If0d485ec9ac2d2ea07858e881869ca34844797ab
Change-Id: If44e296622a1ba99e8221aff222f0e35be1d5de0
Change-Id: I205e1437dbd7d8773b240ee6f2682d5bad4c51d8
Change-Id: Ib08d904a51b513fcd665c80e39cd5f5dc94a08ab
Conflicts: etc/nova/policy.json nova/common/policy.py Change-Id: If5dab15f416f9075805b7b3e0e2c2a19704e514f
Change-Id: I7ff06cdb5d4875b4d6c8a239470bd205c6e7ef23
Change-Id: Id67db96b66cc18c2d77b5163c44caa7aec6e2e07
Change-Id: I8c6fa0fc92d72e2df7d3e0c66cb1ac0e06dd7fc3
Change-Id: Ic38d9ea1c6354a798f32896464691ca64483244a
Change-Id: I400e72cfd6502c41fe9ef0395d2eed73ef3a3214
Change-Id: I90f2e646182149eebaed708ab76d7d72b461a73e
… to having all other roles. Change-Id: If16a7a6aba228e0141562b805528a83d816fa725
Change-Id: I63217ff74a227bd65c354ab084c11cf704231352
Change-Id: I383a9fd316a058fb147627e108419bb6c313c0e4
Change-Id: Ie47799b0eef7077df0d1fc7df8f19928b56d16bb
Change-Id: Icac07bb3beef6d5beb6c41f4f12baff12aeb63ed
…rules. Change-Id: Ib1ea3a6c54c5a36bd6b5a31467ea2b93010d36d1
nova/compute/api.py
Outdated
There was a problem hiding this comment.
I think that this should be be looping through each network and checking network:attach_network with the target set to the specific network
Change-Id: Ia18fee7b45ffe623f15c7fd05bec78614b4f89de
Change-Id: I5635d015467d45f08bb74b7638fa1ba616607375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.