Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom NodeGroup names without environment prefix #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arzianghanchi
Copy link

@Arzianghanchi Arzianghanchi commented Feb 7, 2025

What

  • Updated the environment variable assignment in the NodeGroups configuration to allow the use of a custom NAME.
  • Ensures that if each.value.name is not empty, it is used; otherwise, defaults to var.environment.
  • Provides a fallback mechanism using try() to prevent errors in case of misconfiguration.

Why

  • Enables flexibility in naming NodeGroups without requiring the inclusion of a default environment name.
  • Ensures proper handling of cases where each.value.name is empty, preventing unexpected behavior.
  • Improves maintainability and clarity of the Terraform configuration.

@Arzianghanchi Arzianghanchi changed the title feat: Allow custom NodeGroup names without environment prefix feat: custom NodeGroup names without environment prefix Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants