qlog: change event time field from f32 to f64#2386
Open
Conversation
This change is a stepping stop to supporting https://datatracker.ietf.org/doc/html/draft-ietf-quic-qlog-main-schema-13. It increases the precision of the qlog event time field from 32-bit to 64-bit floating point. While it would have been nice to do this as one atomic change, it ends up touching a lot of dependent crates for such a small technical change. Hence, spliting it out to make other qlog update PRs easier to review. Changes: - Updated qlog Event and JsonEvent time fields from f32 to f64 - Updated Eventable trait set_time() method signature - Updated Event::with_time() and with_time_ex() constructors - Updated all time conversions using as_secs_f32() to as_secs_f64() - Updated qlog-dancer types to use f64 for time coordinates - RTT values remain as f32 since we aren't travelling to outerspace yet.
antoniovicente
approved these changes
Mar 4, 2026
jrouviere
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a stepping stop to supporting
https://datatracker.ietf.org/doc/html/draft-ietf-quic-qlog-main-schema-13.
It increases the precision of the qlog event time field from
32-bit to 64-bit floating point.
While it would have been nice to do this as one atomic change,
it ends up touching a lot of dependent crates for such a small
technical change. Hence, spliting it out to make other qlog
update PRs easier to review.
Changes: