Skip to content

fix: add shell: true on Windows for execFileSync calls #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
evil1morty wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −5
Draft

fix: add shell: true on Windows for execFileSync calls #742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5220036
fix: add `shell: true` on Windows for execFileSync calls
evil1morty Apr 1, 2026
ae574e6
style: break long execFileSync lines to fit printWidth: 100
evil1morty Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/vinext/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ async function buildApp() {
const installCmd = detectPackageManager(process.cwd()).replace(/ -D$/, "");
const [pm, ...pmArgs] = installCmd.split(" ");
console.log(" Upgrading React for RSC compatibility...");
execFileSync(pm, [...pmArgs, ...reactUpgrade], { cwd: process.cwd(), stdio: "inherit" });
execFileSync(pm, [...pmArgs, ...reactUpgrade], { cwd: process.cwd(), stdio: "inherit", shell: process.platform === "win32" });
}
}

Expand Down Expand Up @@ -567,13 +567,13 @@ async function lint() {
try {
if (hasEslint && hasNextLintConfig) {
console.log(" Using eslint (with existing config)\n");
execFileSync("npx", ["eslint", "."], { cwd, stdio: "inherit" });
execFileSync("npx", ["eslint", "."], { cwd, stdio: "inherit", shell: process.platform === "win32" });
} else if (hasOxlint) {
console.log(" Using oxlint\n");
execFileSync("npx", ["oxlint", "."], { cwd, stdio: "inherit" });
execFileSync("npx", ["oxlint", "."], { cwd, stdio: "inherit", shell: process.platform === "win32" });
} else if (hasEslint) {
console.log(" Using eslint\n");
execFileSync("npx", ["eslint", "."], { cwd, stdio: "inherit" });
execFileSync("npx", ["eslint", "."], { cwd, stdio: "inherit", shell: process.platform === "win32" });
} else {
console.log(
" No linter found. Install eslint or oxlint:\n\n" +
Expand Down
7 changes: 6 additions & 1 deletion packages/vinext/src/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,7 @@ function installDeps(root: string, deps: MissingDep[]): void {
execFileSync(pm, [...pmArgs, ...depSpecs], {
cwd: root,
stdio: "inherit",
shell: process.platform === "win32",
});
}

Expand Down Expand Up @@ -1210,6 +1211,10 @@ function runWranglerDeploy(root: string, options: Pick<DeployOptions, "preview"
cwd: root,
stdio: "pipe",
encoding: "utf-8",
// On Windows, .bin/wrangler is a .cmd wrapper; execFileSync can't run
// it without a shell. Enabling shell only on win32 keeps the
// no-shell-injection guarantee on other platforms.
shell: process.platform === "win32",
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice — the comment here is clear and well-scoped. Just noting that the other comment a few lines below (line 1228: "Use execFileSync to avoid shell injection") is now slightly inaccurate on Windows. Consider updating that one too to acknowledge the platform split, since both comments describe the same call site.

};

const { args, env } = buildWranglerDeployArgs(options);
Expand Down Expand Up @@ -1275,7 +1280,7 @@ export async function deploy(options: DeployOptions): Promise<void> {
console.log(
` Upgrading ${reactUpgrade.map((d) => d.replace(/@latest$/, "")).join(", ")}...`,
);
execFileSync(pm, [...pmArgs, ...reactUpgrade], { cwd: root, stdio: "inherit" });
execFileSync(pm, [...pmArgs, ...reactUpgrade], { cwd: root, stdio: "inherit", shell: process.platform === "win32" });
}
}
const missingDeps = getMissingDeps(info);
Expand Down
Loading