Mta kiss build - #1330
Open
joergdw wants to merge 3 commits into
Open
Conversation
Prefer long-form command options for readability: rm --recursive --force instead of rm -rf, and mktemp --directory instead of mktemp -d. Both stem from the standalone-mbt build changes; no behavior change.
joergdw
marked this pull request as ready for review
July 24, 2026 14:42
|
joergdw
commented
Jul 24, 2026
| # `path: scheduler` runs commands from scheduler/; the make targets pushd | ||
| # into scheduler/ and expect the repo root, so invoke make from the parent. | ||
| - make -C .. scheduler.clean build-scheduler | ||
| - make scheduler.clean build-scheduler |
Contributor
Author
There was a problem hiding this comment.
This still needs the --directory.
joergdw
commented
Jul 24, 2026
Comment on lines
+15
to
+16
| AUTOSCALER_PLUGIN_VERSION ?= $(shell \ | ||
| nix eval --raw '.#app-autoscaler-cli-plugin.version') |
Contributor
Author
There was a problem hiding this comment.
This could cause issues on classical cloudMbt-build-images as nix is not available there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #1322.