Fix bump blob bootstrap flow - #1885
Merged
Merged
Conversation
The bump-blob task assumed blobs already exist in the blobstore.
When adding a new blob (e.g. postgresql-16) for the first time,
grep -v returns exit code 1 with no matches, which causes the
script to fail under set -eo pipefail.
Changes:
- Wrap grep in { ... || true; } to tolerate zero matches
- Skip bosh remove-blob when no existing blob is found
- Skip UPDATE_REFERENCES when there is no current version
- Use appropriate commit message for first-time additions
ai-assisted=yes
[TNZ-83781] Pull in new postgres lib for backup-and-restore-sdk
Made-with: Cursor
Co-authored-by: Colin Shield <colin.shield@broadcom.com>
Co-authored-by: Nishad Mathur <nishad.mathur@broadcom.com>
Not 100% sure this is right or not. ai-assisted=yes [TNZ-83781] Pull in new postgres lib for backup-and-restore-sdk Co-authored-by: Nishad Mathur <nishad.mathur@broadcom.com>
ai-assisted=yes [TNZ-83781] Pull in new postgres lib for backup-and-restore-sdk Co-authored-by: Nishad Mathur <nishad.mathur@broadcom.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI “bump blob” automation to better support first-time blob additions (bootstrapping), and publishes a new backup-and-restore-sdk final release version (1.19.50) with updated build metadata and pipeline wiring.
Changes:
- Add explicit “first-time add” handling to
ci/tasks/bump-blob/task.sh(avoid removing non-existent blobs; adjust commit message and reference-updating behavior). - Publish final release metadata for
backup-and-restore-sdk1.19.50(release manifest + build indices). - Adjust CI pipeline git resources and job gating (
passed:constraints) to enforce the intended bootstrap flow.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| releases/backup-and-restore-sdk/index.yml | Adds the 1.19.50 release entry to the release index. |
| releases/backup-and-restore-sdk/backup-and-restore-sdk-1.19.50.yml | Adds the release manifest for version 1.19.50. |
| packages/database-backup-restorer-postgres-16/packaging | Modifies the Postgres 16 packaging configure invocation (ICU-related env vars). |
| ci/tasks/bump-blob/task.sh | Implements first-time blob add behavior and safer update/commit logic for bootstrapping. |
| ci/pipeline.yml | Pins git resources to the configured branch and re-enables passed: constraints for bootstrap sequencing. |
| .final_builds/packages/s3-blobstore-backup-restorer/index.yml | Adds a new final build entry for the s3 package. |
| .final_builds/packages/database-backup-restorer/index.yml | Adds a new final build entry for the database-backup-restorer package. |
| .final_builds/packages/database-backup-restorer-postgres-16/index.yml | Introduces the final builds index for the Postgres 16 package. |
| .final_builds/packages/database-backup-restorer-postgres-15/index.yml | Adds a new final build entry for the Postgres 15 package. |
| .final_builds/jobs/database-backup-restorer/index.yml | Adds a new final build entry for the database-backup-restorer job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
CLA bot was rejecting the bots signature Co-authored-by: Colin Shield <colin.shield@broadcom.com>
ai-assisted=yes [TNZ-83781] Pull in new postgres lib for backup-and-restore-sdk Co-authored-by: Colin Shield <colin.shield@broadcom.com>
Alphasite
force-pushed
the
fix-bump-blob-first-time-add
branch
from
March 6, 2026 22:16
ddad390 to
19bb3de
Compare
KauzClay
approved these changes
Mar 6, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will now handle bootstrapping explicitly