Use golang/protobuf instead of gogo/protobuf #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing used correctly)
Remove extra Proto for ProtoRoutes Regen protos
Rearrange some code for scope changes
Regen protos
Regen protos
Remove unnecessary check on len(msg.Enums) Regen protos
Change file.proto definitions to match new convention Regen protos Resolve go vet and staticcheck
Regen protos Resolve issues with unit tests
1 task
Add Protobuf Models doc
ebroberson
force-pushed
the
protobuf-with-plugin
branch
from
99751b1 to
0118bf6
Compare
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
| New way: | ||
| DesiredLRPUpdate -> ProtoDesiredLRPUpdate -> Protobuf binary -> ProtoDesiredLRPUpdate -> DesiredLRPUpdate | ||
|
|
||
| 2024-05-15: It remains to be seen if this extra layer is going to cause performance issues |
There was a problem hiding this comment.
This is an ominous comment. Has any further investigation been done on the potential perf issues?
There was a problem hiding this comment.
No specific perf testing has been done yet.
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
geofffranks
reviewed
Feb 19, 2025
|
I raised a couple questions, and fund a number of spots that could use either cleanup, or uncommenting depending on if the code is actually needed anymore. I don't fully understand all the reasons for protoc-gen-bbs, and trying to understand how it's templating the generated code is breaking my brain. This is very impressive, well done! |
ebroberson
force-pushed
the
protobuf-with-plugin
branch
from
151cecf to
889d496
Compare
Add performance results for old (gogo) protobufs
ebroberson
force-pushed
the
protobuf-with-plugin
branch
from
889d496 to
c92f8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gogo/protobuf has been deprecated for years. We should be using up-to-date protobufs provided by google.golang.org/protobuf. In order to fit our use cases, a protobuf plugin (
protoc-gen-go-bbs) has been created to catch any customizations we want to add.Backward Compatibility
Breaking Change? No