-
Notifications
You must be signed in to change notification settings - Fork 184
feat: Add dualstack support for AWS Infrastructure #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dualstack support for AWS Infrastructure #640
Conversation
For completeness, I've discussed with @Volatus that the IPv6 config should be optional, not default. The PR is being reworked to base IPv6 or not on a terraform variable. This variable will then be set by the Go code appropriately and defaults to "IPv4 only". |
Hi @Volatus , thanks for your contribution :-). I have the following questions:
|
@oliver-heinrich, please note that "upgrade" is not in scope. Recreate would be your option. See also #632, which contains what was agreed with the BOSH team (via @rkoster). |
4fca9ea
to
47a626b
Compare
LB wise it's occurred to me that we should replace the Here's an overview of the differences between the LB variants on AWS, I think we may need to use
Theoretically this could be possible. (although I run into clashing security group rules when trying to upgrade from IPv4 to dualstack but it downgrades just fine from dualstack to IPv4) |
@Volatus : Thank you for the info. |
I would prefer moving the LB changes into a separate PR. |
40de513
to
59e04b3
Compare
@Volatus could you please update the description with the latest change state. |
Makes the necessary changes to the VPC, subnets, security groups and gateways to add IPv6 Dualstack support. Signed-off-by: Ismayil Mirzali <[email protected]>
Signed-off-by: Ismayil Mirzali <[email protected]>
59e04b3
to
2d52540
Compare
@beyhan @ramonskie, the description has been updated. Please don't forget about this PR :D As noted, this is part 1 of X for adding IPv6 dual stack support. The next step will be to process the new TF vars when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated changes on our AWS account, with changes as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
var.dualstack
variable, which defaults tofalse
.dualstack
is also added as a Terraform output so that Bosh will have a way of determining whether it has to consume IPv6 specific outputs or not.