feat: Add IPv6 Compatible NLBs for AWS #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
* Adds NLB variants of existing classic load balancers * Adds dualstack support on the NLBs * CF TCP LB is now limited to 50 ports, instead of 100 Signed-off-by: Ismayil Mirzali <[email protected]>
Signed-off-by: Ismayil Mirzali <[email protected]>
Volatus
force-pushed
the
feat/aws-ipv6-nlbs
branch
from
b787fbc to
c2e49a7
Compare
beyhan
requested review from
a team,
selzoc and
ramonskie
and removed request for
a team
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
aramprice
approved these changes
May 22, 2025
ramonskie
approved these changes
May 29, 2025
Volatus
force-pushed
the
feat/aws-ipv6-nlbs
branch
from
34b3f78 to
0405749
Compare
Signed-off-by: Ismayil Mirzali <[email protected]>
Volatus
force-pushed
the
feat/aws-ipv6-nlbs
branch
from
0405749 to
546515e
Compare
|
@Volatus - could you please take a look at the unit test failures? |
aramprice
moved this from Pending Review | Discussion
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
|
@aramprice yeah I'm trying to fix them |
|
Waiting for the unit tests to be fixed |
|
Sorry for the delay with the unit tests. They're fixed now. |
peanball
force-pushed
the
feat/aws-ipv6-nlbs
branch
from
2392355 to
b088c06
Compare
github-project-automation
bot
moved this from Waiting for Changes | Open for Contribution
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CF LB and the Isolation Segments LBs are Classic Load Balancers, which only support IPv4. To add dualstack support for Ingress, we need to create NLBs instead.
This PR adds a new LB type,
nlbwhich create all the appropriate resources. There are no changes toconcourseorcflb types, these work as before.It also makes the further changes to OPs Generator to create an entry per for IPv4 and IPv6 when
dualstackis enabled.