Keep Usage Event records of running apps and services #4646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyvuu-dave
changed the title
joyvuu-dave
force-pushed
the
keep_running_records
branch
3 times, most recently
from
c3e6033 to
4d6c72b
Compare
joyvuu-dave
force-pushed
the
keep_running_records
branch
2 times, most recently
from
05b4600 to
801091c
Compare
joyvuu-dave
force-pushed
the
keep_running_records
branch
2 times, most recently
from
eaf204a to
8d00a7d
Compare
joyvuu-dave
force-pushed
the
keep_running_records
branch
5 times, most recently
from
080fd89 to
05ed08a
Compare
joyvuu-dave
force-pushed
the
keep_running_records
branch
6 times, most recently
from
7786a13 to
103ed97
Compare
- Change initialize signature to use keyword argument: cutoff_age_in_days: - Rename internal variable @days_ago to @cutoff_age_in_days for consistency
- Add keep_running_records parameter to OldRecordCleanup - Implement exclude_running_records method to retain START/CREATED records without corresponding STOP/DELETED records - Enable keep_running_records for AppUsageEvent and ServiceUsageEvent cleanup - Add indexes for increasing performance on state queries - Add comprehensive unit tests The exclude_running_records method identifies START records that have matching STOP records while keeping START records without matching STOPs. This prevents premature deletion of usage event records for long-running apps and services, ensuring consumers can always determine the true start time of active resources.
joyvuu-dave
force-pushed
the
keep_running_records
branch
from
6b572a3 to
1a031fc
Compare
evanfarrar
approved these changes
Jan 7, 2026
PeteLevineA
approved these changes
Jan 8, 2026
lib/database/old_record_cleanup.rb
Outdated
| end | ||
|
|
||
| def has_duration?(model) | ||
| return true if model == VCAP::CloudController::AppUsageEvent |
Member
There was a problem hiding this comment.
One nit here that might help in testing these models. Perhaps add a metadata config for testing these conditions?
example:
module VCAP::CloudController
class AppUsageEvent < Sequel::Model
...
def self.metadata_config (probably some better name)
{
beginning_state: ProcessModel::STARTED,
ending_state: ProcessModel::STOPPED,
guid_column: :app_guid
}
end
Contributor
Author
There was a problem hiding this comment.
I like this idea. I just pushed up a refactor.
Benjamintf1
previously approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #4182.
It solves the issue of consumers of Usage Records not having a way of determining the current state of running apps and services.
With this change, usage event records related to running Apps and Services are kept from being pruned during the normal cleanup job.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests