Relocate config-server to src/ - #13
Merged
Merged
Conversation
aramprice
force-pushed
the
remove-gopath-ism
branch
from
July 2, 2026 00:02
6dd00fd to
cc01a51
Compare
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
aramprice
force-pushed
the
remove-gopath-ism
branch
3 times, most recently
from
July 7, 2026 19:33
094a7a2 to
dc598af
Compare
aramprice
marked this pull request as ready for review
July 7, 2026 21:08
In modern golang there's no need to use `github.com/cloudfoundry/config-server/` directory prefixing.
aramprice
force-pushed
the
remove-gopath-ism
branch
from
July 8, 2026 00:23
dc598af to
63601b7
Compare
ystros
previously approved these changes
Jul 8, 2026
ystros
left a comment
ystros
left a comment
Contributor
There was a problem hiding this comment.
Assuming those integration asset files weren't used, seem fine.
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Member
Author
turns out it is needed but somehow I missed that.. probably |
ystros
reviewed
Jul 8, 2026
aramprice
force-pushed
the
remove-gopath-ism
branch
from
July 8, 2026 23:45
ab25e8d to
4276681
Compare
- remove unused scripts - run ginkgo suite directly instead of compiling a `.test` binary - test helpers run mysql / postgresql db setup commands directly - remove db setup shell script - tests derive config file name based on DB value, simplifies scripts
aramprice
force-pushed
the
remove-gopath-ism
branch
from
July 8, 2026 23:54
4276681 to
e3e1822
Compare
ystros
approved these changes
Jul 8, 2026
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In modern golang there's no need to use
github.com/cloudfoundry/config-server/directory prefixing.