Skip to content

Commit

Permalink
Pin busybox image tag
Browse files Browse the repository at this point in the history
We were seeing test failures due to the busybox image having been
updated on Docker Hub, and our tests not specifying an expected version.
Pinned to 1.26.2 (latest tag at current time)

Signed-off-by: Gareth Clay <[email protected]>
  • Loading branch information
MissingRoberto authored and spikymonkey committed Jan 16, 2017
1 parent 806caf2 commit 8389c94
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions integration/groot/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ var _ = Describe("Create", func() {
BeforeEach(func() {
_, err := Runner.Create(groot.CreateSpec{
ID: "my-busybox",
BaseImage: "docker:///busybox",
BaseImage: "docker:///busybox:1.26.2",
})
Expect(err).NotTo(HaveOccurred())

Expand Down Expand Up @@ -364,7 +364,7 @@ var _ = Describe("Create", func() {
BeforeEach(func() {
_, err := Runner.Create(groot.CreateSpec{
ID: "my-busybox",
BaseImage: "docker:///busybox",
BaseImage: "docker:///busybox:1.26.2",
})
Expect(err).NotTo(HaveOccurred())

Expand Down Expand Up @@ -749,7 +749,7 @@ var _ = Describe("Create", func() {
JustBeforeEach(func() {
createSpec = groot.CreateSpec{
ID: "my-busybox",
BaseImage: "docker:///busybox",
BaseImage: "docker:///busybox:1.26.2",
}

_, err := Runner.Create(createSpec)
Expand Down
2 changes: 1 addition & 1 deletion testhelpers/base_images.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var BusyBoxImage = BaseImage{
{
BlobID: "sha256:fdab12439263ca89c449f09a489b6fbf40af8526a3dda279c8954451703641c3",
DiffID: "sha256:68737f5031b303067faacb264cd3b1466973da762bd83d4381e5396e6a4b79a8",
ChainID: "sha256:c85de82f7789ba8696cf905ea603deccc1b082db21181117e1f74d1dd77adf47",
ChainID: "sha256:38ac8d0f5bb30c8b742ad97a328b77870afaec92b33faf7e121161bc78a3fec8",
},
},
}

0 comments on commit 8389c94

Please sign in to comment.