Skip to content

Replace fixed timeout with an eventually with a higher timeout - #84

Merged
kimago merged 1 commit into
mainfrom
fix-flaky-status-log-test
Dec 19, 2025
Merged

Replace fixed timeout with an eventually with a higher timeout#84
kimago merged 1 commit into
mainfrom
fix-flaky-status-log-test

Conversation

@abg

@abg abg commented Nov 7, 2025

Copy link
Copy Markdown
Member

Observed a test failure in a slow CI worker because the hardcoded "sleep" in this test was not long enough.

Now the test polls until it observes the expected backend change - or times out.

Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.

Feature or Bug Description

What does this PR change?

Motivation

Tell us about the problem you are facing, with context, that this PR solves.

Related Issue

If this PR was first opened as an issue, please provide the link to that issue here.

Observed a test failure in a slow CI worker because the hardcoded
"sleep" in this test was not long enough.

Now the test polls until it observes the expected backend change - or
times out.
@abg
abg force-pushed the fix-flaky-status-log-test branch from ca37d30 to 09d626c Compare December 15, 2025 15:45
@abg
abg requested a review from kimago December 15, 2025 15:45
@abg

abg commented Dec 15, 2025

Copy link
Copy Markdown
Member Author

Rebased to fix merge conflicts. @kimago Please review when you have a moment.

@kimago kimago left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Dec 19, 2025
@kimago
kimago merged commit 02fb854 into main Dec 19, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Dec 19, 2025
@abg
abg deleted the fix-flaky-status-log-test branch December 23, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants