Skip to content

Conversation

@bmo-at-a9s
Copy link
Contributor

Description

The fallback parsing of cf services was neglecting the fact that the database URI might contain query parameters.
This PR introduces changes to accomodate them, parse them out correctly and add them to the configuration struct.

Motivation and Context

How Has This Been Tested?

Unit tests have been added to cover this functionality. Additionally, a staging deployment including a database uri with query params was used to verify that the change works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant