Update #2
Open
Update #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns need to be updated
jlipps
approved these changes
Jan 19, 2019
Collaborator
jlipps
left a comment
jlipps
left a comment
There was a problem hiding this comment.
wow, this is a big update. code changes LGTM as long as you fired up the app and it works as intended!
Member
Author
|
You know what, I ran the ios app, but I need to check the Android app to
make sure that works.
…On Fri, Jan 18, 2019 at 8:12 PM Jonathan Lipps ***@***.***> wrote:
***@***.**** approved this pull request.
wow, this is a big update. code changes LGTM as long as you fired up the
app and it works as intended!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABc4sd88b_zgAqAa9ZN4PsjQElHgoWzRks5vEps2gaJpZM4aI21o>
.
|
Member
Author
|
Android build isn't working. Filed issue: wix/react-native-navigation#4623 |
…oved since there's no documentation for it on v2 of react-native-navigation yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update:
react-native
react-native-navigation
react-native-vector icons
react-native-elements