feat(cluster): add support for env and envFrom #610
+91
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahaquielxo
requested review from
itay-grudev,
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
size:M
|
@itay-grudev hello. Any ideas how can I force PR review, please? |
|
Could you please include an example in the non-default configuration test? |
itay-grudev
requested changes
Jun 19, 2025
- introduce `cluster.env` and `cluster.envFrom` in values.yaml - render them conditionally in templates/cluster.yaml under the Postgres container Signed-off-by: Sahaquielxo <[email protected]>
Signed-off-by: Sahaquielxo <[email protected]>
|
@itay-grudev I hope this will be enough. Let me know if I have to add anything else. |
zied-jt
suggested changes
Jul 9, 2025
Comment on lines
+45
to
+52
| {{- if .Values.cluster.env }} | ||
| env: | ||
| {{ toYaml .Values.cluster.env | indent 4 }} | ||
| {{- end }} | ||
| {{- if .Values.cluster.envFrom }} | ||
| envFrom: | ||
| {{ toYaml .Values.cluster.envFrom | indent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Thank you for your contribution.
The yamllint fails, can you update With this changes:
Suggested change
| {{- if .Values.cluster.env }} | |
| env: | |
| {{ toYaml .Values.cluster.env | indent 4 }} | |
| {{- end }} | |
| {{- if .Values.cluster.envFrom }} | |
| envFrom: | |
| {{ toYaml .Values.cluster.envFrom | indent 4 }} | |
| {{- end }} | |
| env: | |
| {{ toYaml .Values.cluster.env | nindent 4 }} | |
| {{- end }} | |
| {{- if .Values.cluster.envFrom }} | |
| envFrom: | |
| {{ toYaml .Values.cluster.envFrom | nindent 4 }} | |
| {{- end }} |
The chainsaw test succeed after the fix.
zied-jt
suggested changes
Jul 10, 2025
Comment on lines
+84
to
+85
| ---------------------------------------------- | ||
| Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2) |
There was a problem hiding this comment.
Can you also remove these lines 84-85
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.envandcluster.envFromin values.yamlFix #609 issue