Skip to content

Add reference to the secret containing the region name #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add reference to the secret containing the region name #624

wants to merge 1 commit into from

Conversation

KhizerJaan
Copy link

No description provided.

@KhizerJaan KhizerJaan requested a review from itay-grudev as a code owner July 24, 2025 08:46
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. chart( cluster ) Related to the cluster chart labels Jul 24, 2025
@zied-jt
Copy link

zied-jt commented Jul 28, 2025

Thank you @KhizerJaan for this contribution.

What do you think about getting the region from values like Line 19 before searching into the secret.
It's more common to have the region declared near the bucket endpoint at the values level, we can fallback looking for the region in the secret if it's empty on values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itay-grudev itay-grudev Awaiting requested review from itay-grudev itay-grudev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chart( cluster ) Related to the cluster chart size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhizerJaan @zied-jt