feat(cloudnative-pg): add metrics from cluster-example-monitoring.yaml #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pat Riehecky <[email protected]>
jcpunk
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
itay-grudev
as code owners
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example metrics from https://github.com/cloudnative-pg/cloudnative-pg/blob/main/docs/src/samples/cluster-example-monitoring.yaml#L27 are not present in the helm chart's default metrics list.
These metrics are also not present in https://github.com/cloudnative-pg/cloudnative-pg/blob/main/releases/cnpg-1.26.1.yaml and should probably be added there too.
I'd love for all 3 to have the same metrics so things are consistent. If the ones from the example are not useful and just provided as a template, a comment in the yaml should be sufficient to close this out without merge.
see also : #103