Add support for additionalCommandArgs and configurable secretKey fields in barmanObjectStore. (fixes #653)

[austinmarten1]

• Add accessKeyIdField and secretAccessKeyField to backups.secret for custom S3 credential key fields

• Add additionalCommandArgs support for both wal and data sections in barmanObjectStore

  Fixes Add support for additionalCommandArgs and configuratable S3 secret keys. #653

[patstevens4]

+1

[ncwade]

+1

[jacob-steward]

Looks great!

I appreciate exposing the additional functionality via values to save having to fork the chart.

[ThisIsntTheWay]

Please note that if custom S3 credential key fields are set and a user passes S3 creds directly in the values (such as backups.s3.accessKey and backups.s3.secretKey), the generated secret will still use the hardcoded ACCESS_KEY_ID and ACCESS_SECRET_KEY strings, causing a mismatch in the barman storage config.
The same applies to the recovery S3 secret.

Additionally, this change doesn't impact the barman config when recovery is configured in the chart.
You would need to add the same fields from .Values.backups.secret to .Values.recovery.secret.
(I guess recovery is technically out of scope here, but this would also greatly help my use case 😃)

[austinmarten1]

Please note that if custom S3 credential key fields are set and a user passes S3 creds directly in the values (such as backups.s3.accessKey and backups.s3.secretKey), the generated secret will still use the hardcoded ACCESS_KEY_ID and ACCESS_SECRET_KEY strings, causing a mismatch in the barman storage config. The same applies to the recovery S3 secret.

Additionally, this change doesn't impact the barman config when recovery is configured in the chart. You would need to add the same fields from .Values.backups.secret to .Values.recovery.secret. (I guess recovery is technically out of scope here, but this would also greatly help my use case 😃)

Helps my use case as well! I can add it in here.

[ThisIsntTheWay]

Looks good, small nitpick about formatting.

[ThisIsntTheWay]

Let's have comments be in the format of # -- My comment like the rest to be consistent.

[austinmarten1]

Looks good, small nitpick about formatting.

Done