Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include talkID in viewCount #545

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

ystkfujii
Copy link
Contributor

@ystkfujii ystkfujii commented Feb 16, 2025

Summary

  • dk-weaver の ViewTrack 実行時にtalk_idを送付するように修正しました。

背景

補足

  • 最終的には、Karteの処理を置換する必要があるが、このPRでは対応しない
    • おそらく、次回イベントで並行して動かしてみて良さそうであれば、削除を検討という流れかなと思っています
  • 確認したこと

@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Feb 16, 2025
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
Copy link

gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Feb 16, 2025
@ystkfujii ystkfujii marked this pull request as ready for review February 16, 2025 16:15
@jacopen jacopen merged commit 54aa29f into main Feb 17, 2025
5 checks passed
@jacopen jacopen deleted the feat/include_talkid_in_mutate branch February 17, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewapps Build ReviewApp environment automatically if this label is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants