Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Message model #2293

Merged
merged 1 commit into from
May 8, 2024
Merged

Remove unused Message model #2293

merged 1 commit into from
May 8, 2024

Conversation

onk
Copy link
Collaborator

@onk onk commented Apr 29, 2024

This commit removes the Message model, which was introduced in PR #213.
The model was maybe intended for a chat feature, but the related functionality was removed within the same PR:

  • introduced
  • RoomChannel and tracks#realtime implementation was removed
  • render partial: 'message' was also deleted

Copy link

@github-actions github-actions bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Apr 29, 2024
This commit removes the Message model, which was introduced in PR #213.
The model was maybe intended for a chat feature, but the related functionality was removed within the same PR:

* introduced
  - 425c04b
* RoomChannel and tracks#realtime implementation was removed
  - 68427b8
* `render partial: 'message'` was also deleted
  - 6e14c40
@onk onk force-pushed the remove_message branch from d12358b to 42a37eb Compare April 29, 2024 04:24
Copy link

Simplecov Report

Covered Threshold
61.06% 60%

@ShotaKitazawa ShotaKitazawa removed the reviewapps Build ReviewApp environment automatically if this label is granted label May 5, 2024
@jacopen jacopen merged commit ecd02de into main May 8, 2024
5 checks passed
@jacopen jacopen deleted the remove_message branch May 8, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants