チェックイン用のAPIエンドポイントを追加 #2300
Merged
チェックイン用のAPIエンドポイントを追加 #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
takaishi
commented
May 5, 2024
•
takaishi
commented
- イベントとセッションそれぞれにチェックイン用のエンドポイントを追加しました
- UI側の実装を楽にするため追記型にして、同じ参加者でも何回でもチェックインできるようにしています。
github-actions
bot
added
the
reviewapps
takaishi
force-pushed
the
feat/add-check-in-api
branch
from
46430aa to
7017af1
Compare
takaishi
force-pushed
the
feat/add-check-in-api
branch
from
7017af1 to
324cf85
Compare
Simplecov Report
|
|
CIこけてるのなんだこれ |
oshiro3
reviewed
May 19, 2024
app/models/conference.rb
Outdated
| @@ -73,6 +73,8 @@ class Conference < ApplicationRecord | |||
| has_many :admin_profiles | |||
| has_many :media_package_harvest_jobs | |||
| has_many :rooms | |||
| has_many :check_in_conferences | |||
| has_many :check_in_talks | |||
There was a problem hiding this comment.
check_in_talks は profile-talk 間の relation な気がします
| create_table :check_in_conferences do |t| | ||
| t.belongs_to :conference, null: false, foreign_key: true | ||
| t.belongs_to :profile, null: false, foreign_key: true | ||
| t.datetime :timestamp, null: false |
There was a problem hiding this comment.
この timestamp column は多分フロント側でチェックインした時間だと思うのですが、 timestamp は SQL の予約語と被ってしまうので使用は避けた方がベターな気がします（絶対に避けるべきという強い意志ではないです）
There was a problem hiding this comment.
確かになと思ったのでリネームしました！
| def create | ||
| @params = check_in_conference_params(JSON.parse(request.body.read, { symbolize_names: true })) | ||
| profile = Profile.find(@params[:profileId]) | ||
| timestamp = Time.at(@params[:timestamp]) |
There was a problem hiding this comment.
rails では TimeWithZone が利用されるのでそちらに合わせてしまうのがよさそうかと
Suggested change
| timestamp = Time.at(@params[:timestamp]) | |
| timestamp = Time.zone.at(@params[:timestamp]) |
|
CI がこけてる件はこの commit で修正されていそうでした！ |
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
commit: cloudnativedaysjp/dreamkast@d65f257 Co-authored-by: GitHub Action <[email protected]>
takaishi
force-pushed
the
feat/add-check-in-api
branch
from
d65f257 to
39159a9
Compare
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
commit: cloudnativedaysjp/dreamkast@39159a9 Co-authored-by: GitHub Action <[email protected]>
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
commit: cloudnativedaysjp/dreamkast@d3cc328 Co-authored-by: GitHub Action <[email protected]>
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 19, 2024
commit: cloudnativedaysjp/dreamkast@1b9f7b4 Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.