Feature/121.2 apply blueprint continuously #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntinuously' into feature/121.2-apply-blueprint-continuously
…ency [#125] ignore nginx dependency
…y-blueprint-continuously # Conflicts: # CHANGELOG.md # pkg/application/stateDiffUseCase_test.go # pkg/domain/dogu_test.go # pkg/domainservice/validateDependenciesDomainUseCase.go
The LastApplySucceeded contains any errors happening in the apply steps. It greatly reduces the complexity of setting conditions, because it will not reset at StateDiff in contrast to the Applied-Conditions before.
| values: | ||
| images: | ||
| blueprintOperator: cloudogu/k8s-blueprint-operator:2.7.0 | ||
| blueprintOperator: cloudogu/k8s-blueprint-operator:2.8.0 |
There was a problem hiding this comment.
are these changes from the original develop/main?
There was a problem hiding this comment.
yes, is this bad? We needed them for the test with argoCD. Are we not allowed to merge it into V2?
There was a problem hiding this comment.
I just looked at the changes again and they all seem compatible with v2
pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository.go
Outdated
Show resolved
Hide resolved
pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository.go
Outdated
Show resolved
Hide resolved
This is unnecessary, because it will be recalculated on every reconciliation
This is necessary to avoid potential restarts of dogus with unfitting config (for another dogu version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.