feat(nvd): update cves - #1271
Merged
Merged
Conversation
tsim-sap
force-pushed
the
tsim-sap/issue-1242/nvd-update-sves
branch
from
July 30, 2026 13:38
6dc4e1c to
07eb7b6
Compare
tsim-sap
marked this pull request as ready for review
July 30, 2026 20:51
tsim-sap
requested review from
kanstantsinbuklis-sap,
mdrkb and
michalkrzyz
as code owners
July 30, 2026 20:51
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “update mode” to the NVD scanner so it can periodically re-fetch CVEs modified in NVD (by last-modified date) and update existing Heureka Issues/IssueVariants when relevant fields change.
Changes:
- Extend NVD scanner config and main flow to support an update mode with a configurable review interval.
- Add processor logic (
ProcessOrUpdate) plus new GraphQL queries/mutations to fetch and update Issues/IssueVariants. - Extend Helm chart to deploy an additional CronJob for periodic update scans.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scanner/nvd/scanner/config.go | Adds UpdateMode and ReviewIntervalDays config for last-modified update scanning. |
| scanner/nvd/processor/processor.go | Adds update path that queries existing Issues and conditionally updates Issue/IssueVariant. |
| scanner/nvd/main.go | Adds update-mode execution path and passes contexts through processing; adjusts time-window start timestamp. |
| scanner/nvd/client/queries/issuevariant_update.graphql | Adds GraphQL mutation to update an IssueVariant. |
| scanner/nvd/client/queries/issues_query.graphql | Extends issue query to include IssueVariant + CVSS vector for change detection. |
| scanner/nvd/client/queries/issue_update.graphql | Adds GraphQL mutation to update an Issue. |
| scanner/nvd/chart/nvd-scanner/values.yaml | Adds chart values for enabling/scheduling the update CronJob and review interval. |
| scanner/nvd/chart/nvd-scanner/templates/cronjob.yaml | Adds a second CronJob to run the scanner in update mode. |
Comments suppressed due to low confidence (1)
scanner/nvd/main.go:120
- processCVESConcurrently’s semaphore does not actually cap concurrency: the worker goroutines continuously send tokens on an unbuffered channel, and each CVE goroutine consumes one token without returning it, so all CVE goroutines can proceed concurrently. This can cause unbounded parallel GraphQL/API calls (especially problematic in update mode).
// sem is an unbuffered channel meaning that sending onto it will block
// until there's a corresponding receive operation
sem := make(chan struct{})
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Valiantsin Tsimoshyk <v.tsimoshyk@sap.com>
tsim-sap
force-pushed
the
tsim-sap/issue-1242/nvd-update-sves
branch
from
August 7, 2026 17:58
07eb7b6 to
00c9fa2
Compare
MR2011
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an NVD update mode that periodically syncs modified CVEs back into Heureka, plus several additional fixes.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist