Skip to content

feature: add credentialSpecs - #195

Open
getSurreal wants to merge 6 commits into
cloudposse:mainfrom
getSurreal:getSurreal/credentialSpecs
Open

feature: add credentialSpecs#195
getSurreal wants to merge 6 commits into
cloudposse:mainfrom
getSurreal:getSurreal/credentialSpecs

Conversation

@getSurreal

Copy link
Copy Markdown

what

  • Add credentialSpecs parameter

why

  • Support an AWS documented parameter.
  • Needed for gMSA service account used with Active Directory authentication

references

@getSurreal
getSurreal requested review from a team as code owners June 4, 2025 14:58
@mergify mergify Bot added the triage Needs triage label Jun 4, 2025
@getSurreal

Copy link
Copy Markdown
Author

Looks like make init and make readme functionality has been removed. Let me know what the alternative steps are.

@Gowiem Matt Gowie (Gowiem) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify Bot removed the triage Needs triage label Jun 5, 2025
@Gowiem

Copy link
Copy Markdown
Member

/terratest

@getSurreal

Copy link
Copy Markdown
Author

The terratest error doesn't appear to be related to the changes. Any suggestion?

Error: /go/pkg/mod/golang.org/x/net@v0.8.0/http2/transport.go:19:2: package io/fs is not in GOROOT (/__t/go/1.15.15/x64/src/io/fs)

@getSurreal

Copy link
Copy Markdown
Author

/terratest

@durangogt

Copy link
Copy Markdown

Can this PR get merged? It would be helpful for us.

@goruha

Copy link
Copy Markdown
Member

/terratest

@goruha

Copy link
Copy Markdown
Member

/terratest

@getSurreal

Copy link
Copy Markdown
Author

Igor Rodionov (@goruha) Anything I can still help with to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants