Skip to content

fix: use toset(keys(...)) in vpc-endpoints for_each to avoid deprecated .region schema walk #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnoldas Brazys (arnoldasbrazys) wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: use toset(keys(...)) in vpc-endpoints for_each to avoid deprecated .region schema walk #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/vpc-endpoints/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module "gateway_endpoint_label" {
source = "cloudposse/label/null"
version = "0.25.0"

for_each = local.enabled ? data.aws_vpc_endpoint_service.gateway_endpoint_service : {}
for_each = local.enabled ? toset(keys(data.aws_vpc_endpoint_service.gateway_endpoint_service)) : toset([])
attributes = [each.key]

context = module.this.context
Expand All @@ -69,14 +69,14 @@ module "interface_endpoint_label" {
source = "cloudposse/label/null"
version = "0.25.0"

for_each = local.enabled ? data.aws_vpc_endpoint_service.interface_endpoint_service : {}
for_each = local.enabled ? toset(keys(data.aws_vpc_endpoint_service.interface_endpoint_service)) : toset([])
attributes = [each.key]

context = module.this.context
}

resource "aws_vpc_endpoint" "gateway_endpoint" {
for_each = local.enabled ? data.aws_vpc_endpoint_service.gateway_endpoint_service : {}
for_each = local.enabled ? toset(keys(data.aws_vpc_endpoint_service.gateway_endpoint_service)) : toset([])
service_name = data.aws_vpc_endpoint_service.gateway_endpoint_service[each.key].service_name
policy = var.gateway_vpc_endpoints[each.key].policy
vpc_endpoint_type = data.aws_vpc_endpoint_service.gateway_endpoint_service[each.key].service_type
Expand All @@ -93,7 +93,7 @@ resource "aws_vpc_endpoint_route_table_association" "gateway" {
}

resource "aws_vpc_endpoint" "interface_endpoint" {
for_each = local.enabled ? data.aws_vpc_endpoint_service.interface_endpoint_service : {}
for_each = local.enabled ? toset(keys(data.aws_vpc_endpoint_service.interface_endpoint_service)) : toset([])
service_name = data.aws_vpc_endpoint_service.interface_endpoint_service[each.key].service_name
policy = var.interface_vpc_endpoints[each.key].policy
vpc_endpoint_type = data.aws_vpc_endpoint_service.interface_endpoint_service[each.key].service_type
Expand Down
Loading