feat: Add support for rbac resources #797
Conversation
robertoriv
changed the title
There was a problem hiding this comment.
Hey @robertoriv! 👋🏽
Thanks for the contribution, I remember some folks have asked for something like this in the past, but we were reluctant to add it since this chart is not really specific to the k8s source plugin but rather to running cloudquery on k8s, agnostic of the plugins used.
However, since the defaults are sane and do not require lots of extra configurations to make this work, we can indeed add this to the chart.
Do resolve the CR comments and feel free to request another review. 🙏🏽
| @@ -14,7 +14,7 @@ sources: | |||
| maintainers: | |||
| - name: yevgenypats | |||
| email: [email protected] | |||
| version: 38.2.0 | |||
There was a problem hiding this comment.
Version bumps are handled automatically by CI based on the type of commit.
In this case, since the commit is a feat:, the minor will be bumped which is correct.
Do remove this code change here.
| @@ -1,6 +1,6 @@ | |||
| # cloudquery | |||
|
|
|||
|    | |||
There was a problem hiding this comment.
Same as the above, do remove this code change.
| ---------------------------------------------- | ||
| Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0) |
There was a problem hiding this comment.
Why did this get removed?
This PR adds some basic support for RBAC as documented here: https://hub.cloudquery.io/plugins/source/cloudquery/k8s/latest/docs#kubernetes-service-account
Given that a kubernetes deployment of
cloudquerycan't really work without a corresponding role, it might be useful to include it.The feature is off by default (
rbac.create = false). And should continue to produce the previous configuration unless the user wants the rbac functionality turned on.I went ahead and version-bumped the
Chart.yamlfile. Not sure if that's required, or handled by CI. Please let me know if I need to make any changes.