Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add puppeteer-core dependency #43

Merged
merged 1 commit into from
Feb 20, 2025
Merged

chore: Add puppeteer-core dependency #43

merged 1 commit into from
Feb 20, 2025

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Feb 20, 2025

Description

Fixing this issue: https://github.com/cloudscape-design/chat-components/actions/runs/13394949739/job/37411525211?pr=42

Related links, issue #, if available: n/a

How has this been tested?

Ran locally, they pass.

The PR build fails because the mainline build failed. This will pass after this PR is merged

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -101,6 +101,7 @@
"lodash-es": "^4.17.21",
"npm-run-all": "^4.1.5",
"prettier": "^3.2.5",
"puppeteer-core": "^22.15.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (b5b61a9) to head (b1d0edf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          30       30           
  Lines         683      683           
  Branches      109      109           
=======================================
  Hits          668      668           
  Misses         12       12           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review February 20, 2025 14:44
@just-boris just-boris requested a review from a team as a code owner February 20, 2025 14:44
@just-boris just-boris requested review from jperals and removed request for a team February 20, 2025 14:44
@just-boris just-boris added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 4b4c80a Feb 20, 2025
40 of 41 checks passed
@just-boris just-boris deleted the upgrade-vitest branch February 20, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants