Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avatar #8

Merged
merged 11 commits into from
Jun 26, 2024
Merged

feat: Avatar #8

merged 11 commits into from
Jun 26, 2024

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Jun 20, 2024

Description

New avatar component

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner June 20, 2024 16:12
@cansuaa cansuaa requested review from avinashbot and pan-kot and removed request for a team and avinashbot June 20, 2024 16:12
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.88%. Comparing base (af25460) to head (19a380d).
Report is 1 commits behind head on main.

Files Patch % Lines
src/avatar/internal.tsx 97.95% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   96.77%   96.88%   +0.10%     
==========================================
  Files          12       16       +4     
  Lines         217      385     +168     
  Branches       18       51      +33     
==========================================
+ Hits          210      373     +163     
- Misses          7       11       +4     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gethinwebster
gethinwebster previously approved these changes Jun 26, 2024
@cansuaa cansuaa merged commit 097e840 into main Jun 26, 2024
32 checks passed
@cansuaa cansuaa deleted the cansua/genai-avatar branch June 26, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants