Skip to content

Conversation

@zhuangjie1125
Copy link
Contributor

Moves the callback initialization logic from the generic ChatModel to the specific ResponsesAPIChatModel.

This change ensures that EnsureRunInfo is only called for the Responses API flow, where it is actually needed. The GetType method was also added to ResponsesAPIChatModel to support this.

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

Moves the callback initialization logic from the generic ChatModel to the specific ResponsesAPIChatModel.

This change ensures that EnsureRunInfo is only called for the Responses API flow, where it is actually needed. The GetType method was also added to ResponsesAPIChatModel to support this.

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Moves the callback initialization logic from the generic ChatModel to the specific ResponsesAPIChatModel.

This change ensures that EnsureRunInfo is only called for the Responses API flow, where it is actually needed. The GetType method was also added to ResponsesAPIChatModel to support this.
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Need to create a new tag

The following modules have changes and may need version updates:

  • components/model/ark (Current: components/model/ark/v0.1.61)

⚠️ Please create and push new version tags for these modules after merging this PR.

@mrh997 mrh997 self-requested a review January 9, 2026 04:12
@zhuangjie1125 zhuangjie1125 enabled auto-merge (squash) January 9, 2026 06:23
@zhuangjie1125 zhuangjie1125 merged commit b9080db into main Jan 9, 2026
8 checks passed
@zhuangjie1125 zhuangjie1125 deleted the feat/ark_callbacks branch January 9, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants