Skip to content

Stop forwarding session credentials over SSH to EIF builder #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickpell merged 1 commit into from
Mar 23, 2026
Merged

Stop forwarding session credentials over SSH to EIF builder #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/eif-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,7 @@ jobs:
ssh -i /tmp/eif-builder-key.pem \
-o StrictHostKeyChecking=no \
ec2-user@${{ steps.launch-instance.outputs.public_ip }} \
"sudo AWS_ACCESS_KEY_ID='${AWS_ACCESS_KEY_ID}' \
AWS_SECRET_ACCESS_KEY='${AWS_SECRET_ACCESS_KEY}' \
AWS_SESSION_TOKEN='${AWS_SESSION_TOKEN}' \
bash ~/scripts/build-eif-ci.sh \
"sudo bash ~/scripts/build-eif-ci.sh \
'${{ steps.image-uri.outputs.image_uri }}' \
'/tmp/auction.eif' \
'${{ env.AWS_REGION }}'"
Expand Down
7 changes: 3 additions & 4 deletions enclave/scripts/build-eif-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ set -euo pipefail
# OUTPUT_EIF_PATH: Path where the EIF file should be written
# AWS_REGION: (Optional) AWS region, defaults to us-east-1
#
# Environment Variables:
# AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN: AWS credentials
# AWS credentials are provided by the EC2 instance profile (eif-builder-instance)
# via the instance metadata service (IMDS).
#
# Outputs:
# - EIF file at OUTPUT_EIF_PATH
Expand Down Expand Up @@ -71,8 +71,7 @@ validate_prerequisites() {
log "✓ Nitro CLI available: $(nitro-cli --version 2>&1 | head -n1 || echo 'version unknown')"

if ! aws sts get-caller-identity &> /dev/null; then
log_error "AWS credentials not configured"
log_error "Set AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY or attach IAM instance profile"
log_error "AWS credentials not configured — verify the EC2 instance profile is attached"
return 1
fi
log "✓ AWS credentials configured"
Expand Down
Loading