34 26 repeat submit for extraction #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 15, 2023
minump
changed the title
Merged
|
On testing, found an issue in request /extractions/status. Issue captured here #55 A hot fix is implemented in this PR. The request is not sent. Instead the extraction status is set to true (hard-coded). This is ok as there is another check done to check if the specific file type has been generated. |
|
Merging to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on #33
The createUploadExtract function is moved to actions/client file. This makes actions/dataset deal with only dataset actions and actions/file deal with only file actions.
If the POST extraction request fails with status 409, the code waits for 30s and sends a POST request again.
The checkExtractionStatus function in utils/file.js now checks for error in "StatusMessage" from extractor.
Fixes #26
When there is an error in the extractor message, the processing is stopped and client overlay displays "Error in extractor". Better error message display will be worked on in another issue.
Fixes #34
If POST to extraction (
/files/${file_id}/extractions) gives 409 error, the code waits for 30s and resubmits again.