Accept both date and x-date for skew checks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable use in frontend/browsers.
|
thanks for submitting. i'll take a look.
it's minimally maintained. i'm happy to review/merge prs and fix security issues, but don't have the time to dedicate to building new features or a new release myself. |
|
Hi! Did you have time to look at this pull request, or are you waiting for me to fix the checks on Travis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most browsers (tested on Firefox 60.2.0esr, Chrome 70.0.3538.77) do not automatically include date in the HTTP header (and forbid date to be changed/added programmatically). Therefore, Hmmac in its current form cannot be used with skew check, increasing the chance for replay attacks.
I modified lib/hmmac.js to also consider the 'x-date' header for skew check in case 'date' is not set.
Would be great to get this into the library (which I otherwise like a lot) - I hope it's still somewhat maintained.
Cheers,
Grischa