Added parameter to control max reionization z externally#166
Merged
cmbant merged 1 commit intocmbant:masterfrom Mar 25, 2025
Merged
Added parameter to control max reionization z externally#166cmbant merged 1 commit intocmbant:masterfrom
cmbant merged 1 commit intocmbant:masterfrom
Conversation
Owner
|
Thanks, though this is actually a property of BaseTauWithHeReionization not just tanh reionization? |
Contributor
Author
|
Right, shoud I modify implementing set_extra_params for the base class and call super in the child? |
Owner
|
I guess something like that would better fit the structure |
Contributor
Author
|
Implemented! Cobaya kwargs inspection prevents just passing down generic kwargs so the variable name is exposed in the child classes. Added missing docstrings! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change allows to set max reionization redshift from cobaya - avoiding the annoying "Did not converge to optical depth" error.
max z effectively sets an implicit prior on tau so it is useful to control it.