Skip to content

Added parameter to control max reionization z externally#166

Merged
cmbant merged 1 commit intocmbant:masterfrom
mraveri:master
Mar 25, 2025
Merged

Added parameter to control max reionization z externally#166
cmbant merged 1 commit intocmbant:masterfrom
mraveri:master

Conversation

@mraveri
Copy link
Contributor

@mraveri mraveri commented Mar 25, 2025

This small change allows to set max reionization redshift from cobaya - avoiding the annoying "Did not converge to optical depth" error.

max z effectively sets an implicit prior on tau so it is useful to control it.

@cmbant
Copy link
Owner

cmbant commented Mar 25, 2025

Thanks, though this is actually a property of BaseTauWithHeReionization not just tanh reionization?

@mraveri
Copy link
Contributor Author

mraveri commented Mar 25, 2025

Right, shoud I modify implementing set_extra_params for the base class and call super in the child?

@cmbant
Copy link
Owner

cmbant commented Mar 25, 2025

I guess something like that would better fit the structure

@mraveri
Copy link
Contributor Author

mraveri commented Mar 25, 2025

Implemented! Cobaya kwargs inspection prevents just passing down generic kwargs so the variable name is exposed in the child classes.

Added missing docstrings!

@cmbant cmbant merged commit 886b17c into cmbant:master Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants