MTD geometry: fix the topology parameters reading for ETL v10

[fabiocos]

PR description:

This PR addresses the issue #47652 . The addition of the ETL scenario v10 (global scenario D119) was not properly accounted for in the acquisition of the input parameters to the MTDTopology, and this causes the geometry navigation, performed during the tracking, to recursively call a method that allocates memory within

cmssw/RecoMTD/DetLayers/src/MTDDetSector.cc

Line 69 in 2bed69b

vector<GeometricSearchDet::DetWithState> MTDDetSector::compatibleDets(const TrajectoryStateOnSurface& startingState,

A similar problem happened during the development of #47353 . The comparison between enum class objects requires the static_cast<int> conversion to work properly, that was not correctly applied in MTDParametersFromDD.

PR validation:

The update is clearly needed, it allows wf 33634.0 to run smoothly in single threaded mode.
Repeated checks show that the initial commit do not solve the issue, neither in single nor in multi-threaded mode.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47660/44195

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• Geometry/MTDGeometryBuilder (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test workflow 33234.0,33634.0

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59bf7e/45145/summary.html
COMMIT: 702d294
CMSSW: CMSSW_15_1_X_2025-03-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47660/45145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4131145
• DQMHistoTests: Total failures: 64
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4131061
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 225 log files, 192 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[fabiocos]

hold

I am still getting memory issue with this update on top of CMSSW_15_1_X_2025-03-21-2300 and 4 threads (tested on cmsdev45). I need to investigate more, although the fix in this PR seems to me anyway needed.

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fabiocos]

It looks like there is a deeper problem in the geometry layout that causes the navigation to keep calling the add method in MTDDetSector, despite the scenarios are now correctly defined. It is likely related to the definition of the topology content itself. This was apparently missed in the checks of the standalone test https://github.com/cms-sw/cmssw/blob/master/RecoMTD/DetLayers/test/mtd_cfg.py#L66 during the development, we are looking more into that.

[fabiocos]

unhold

merging this PR is for sure needed, but it will not solve alone the problem with D119 geometry, that requires additional fixes.

[civanch]

+1

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1