Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(client): run py client through black #1218

Merged
merged 1 commit into from
Jul 11, 2023
Merged

style(client): run py client through black #1218

merged 1 commit into from
Jul 11, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Jun 28, 2023 •
edited
Loading

Part of #962

Summary:

  • Run delphi_epidata.py through black and flynt
  • Recommend "hide whitespace" setting for viewing diffs

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dshemetov dshemetov requested a review from nmdefries June 28, 2023 19:17
nmdefries
nmdefries previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. A couple light/nonblocking comments.

@dshemetov dshemetov requested a review from nmdefries July 10, 2023 19:23
nmdefries
nmdefries previously approved these changes Jul 11, 2023
View reviewed changes
@nmdefries
Copy link
Contributor

Oh, there's a conflict with the version number.

@dshemetov dshemetov requested a review from nmdefries July 11, 2023 18:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.9% 7.9% Duplication

@dshemetov dshemetov merged commit b11875e into dev Jul 11, 2023
@dshemetov dshemetov deleted the ds/format-client branch July 11, 2023 21:16
@BrainIsDead BrainIsDead mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 left review comments

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dshemetov @nmdefries @melange396